I have added a check that the "extra-short form" is not followed by garbage. (And wrote tests for it.) It only accepts , or } now. It never crashed before but had accepted any separator like ; or # and did not check for closing }. That is fixed now.
The error message if } is missing is:
dbChannelCreate: parse error: premature EOF
If garbarge follows instead or a comma, the error is:
dbChannelCreate: lexical error: invalid char in json text.
These are exactly the same error one gets with the "long form" using :{}
Whitespace around the comma are possible just as usual.
---
I could not find a clever way to properly type check chfPluginArgString for char* vs char[] (without writing a new API in C++). Thus I will keep old chfPluginArgString and new chfPluginArgStringAlloc.
--
https://code.launchpad.net/~dirk.zimoch/epics-base/+git/epics-base/+merge/399636
Your team EPICS Core Developers is requested to review the proposed merge of ~dirk.zimoch/epics-base:chfPluginImprovements into epics-base:7.0.
- References:
- [Merge] ~dirk.zimoch/epics-base:chfPluginImprovements into epics-base:7.0 Dirk Zimoch via Core-talk
- Navigate by Date:
- Prev:
Build failed: epics-base base-dbChannel_get_count-unlocked-696 AppVeyor via Core-talk
- Next:
Build failed: epics-base base-integration-697 AppVeyor via Core-talk
- Index:
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
<2021>
2022
2023
2024
- Navigate by Thread:
- Prev:
[Merge] ~dirk.zimoch/epics-base:chfPluginImprovements into epics-base:7.0 Dirk Zimoch via Core-talk
- Next:
Build completed: EPICS Base 7 base-7.0-249 AppVeyor via Core-talk
- Index:
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
<2021>
2022
2023
2024
|