Experimental Physics and
| |||||||||||||||||
|
We had a contractor provide an implementation for the missing piece about 2 years ago which can be found in pva2pva PR #37 but that hasn't been merged to date, probably due to some combination of me and/or Michael not finishing it off. Please give that a go and add a report on the experience to the PR. - Andrew On 6/21/22 9:26 AM, Timo Korhonen
wrote:
Colleagues, The topic of put logging came up in our discussions at ESS again. I found this old thread and tried to scratch my memory where we ended with this. I thought this was working (with PVA as well) but I am not sure anymore, and re-reading the thread could not enlighten me either. Access security works exactly as discussed for us, with Posix groups (PVA-only) and all that, and I assumed that the put-logging issue was resolved as a part of that implementation, but is there still something missing? Timo On 2019-09-06, 14:39, "core-talk-bounces at aps.anl.gov on behalf of Johnson, Andrew N. via Core-talk" <core-talk-bounces at aps.anl.gov on behalf of core-talk at aps.anl.gov> wrote: Hi Michael, > On Sep 4, 2019, at 4:45 AM, Michael Davidsaver <mdavidsaver at gmail.com> wrote: > > https://github.com/epics-modules/caPutLog/blob/b544f92c6efe1df98506b567f3f7e5137965e2a4/caPutLogApp/caPutLogAs.c#L104 > > dbGetField() is used, which of course calls dbScanLock(). > This is done twice, for the "before" and "after" values. > So 'pmessage->data' is not used. > > I guess I can just pass data="" or a dummy value. Please look at commit c5ded30684 in Base. The asTrapWrite.h API was enhanced about 4 years ago in 3.15 and caPutLog is no longer the only external user of it. Tim Mooney's caPutRecorder module *does* rely on pmessage->data. Direct access to the data was added on his request, so he can record exactly what value was put even if the record processing subsequently modifies that field value (puts to the Motor record can fall into that category). Someone could modify caPutLog to make use of the data field instead of calling dbGetField() twice. - Andrew -- Complexity is free, it's Simplicity that takes work.
| ||||||||||||||||
ANJ, 14 Sep 2022 |
·
Home
·
News
·
About
·
Base
·
Modules
·
Extensions
·
Distributions
·
Download
·
· Search · EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing · |