Re: TS - EAST from GMT

[Andrew Johnson <anj@mail.ast.cam.ac.uk>]

Since no one else has raised this yet, I thought I ought to:

> > From csuka@heracc.desy.de Mon Jan 16 06:27:23 1995

> > The code below in tsSubr.c (line 902)  doesn't work if EPICS_TS_MIN_WEST 
> > negative.
> > 
> >     assert(pStamp->secPastEpoch >= tsMinWest * 60);
> > 
> > The correct is (e.g.):
> > 
> >     if (tsMinWest>0) {
> >         assert(pStamp->secPastEpoch >= (unsigned long)(tsMinWest * 60));
> >     }

Isn't it bad practice to put an assert expression inside an if statement like 
that?  I suspect the real correction should be more like:

	assert((tsMinWest <= 0) || 
	       (pStamp->secPastEpoch >= (unsigned long)(tsMinWest * 60)))

I also imagine there ought to be some equivalent test for when tsMinWest is zero 
or negative, but I don't know out what it should be.

(pedant mode OFF)

- Andrew

          ,_}\_.        Andrew Johnson, Technology Division
         /      \       Royal Greenwich Observatory
~~~~~~~~| ,--/;. )~~~~  Madingley Road, Cambridge, UK
    .,  |/  (/  U       Phone: +44 (0)1223 374823
  .`., /_\ . .          Email: anj@mail.ast.cam.ac.uk
     wwWWWww'           WWW: http://cast0.ast.cam.ac.uk/~anj/