Argonne National Laboratory

Experimental Physics and
Industrial Control System

1994  <19951996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020  Index 1994  <19951996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020 
<== Date ==> <== Thread ==>

Subject: Re: TS - EAST from GMT
From: kerstien@luke.atdiv.lanl.gov (Deb Kerstiens)
Date: Tue, 17 Jan 95 09:29:41 MST
> From csuka@heracc.desy.de Mon Jan 16 06:27:23 1995
> Date: Mon, 16 Jan 1995 14:28:52 EST
> From: "Gabor Csuka, DESY - Germany" <csuka@heracc.desy.de>
> To: tech-talk@aps.anl.gov
> Cc: csuka@heracc.desy.de
> Subject: TS - EAST from GMT
> Content-Length: 299
> 
> Hi,
> 
> The code below in tsSubr.c (line 902)  doesn't work if EPICS_TS_MIN_WEST 
> negative.
> 
>     assert(pStamp->secPastEpoch >= tsMinWest * 60);
> 
> The correct is (e.g.):
> 
>     if (tsMinWest>0) {
>         assert(pStamp->secPastEpoch >= (unsigned long)(tsMinWest * 60));
>     }
> 
> 
> 
> Regards, 
> Gabor Csuka
> DESY
> 

There's another error in tsSubr.c (line 877) that incorrectly checks for 
initialization out of range:

        if (tsMinWest > 1380 && tsMinWest < -1380)
            error = 1;

should be 

        if (tsMinWest > 1380 || tsMinWest < -1380)
            error = 1;

If you're fixing your copies, might as well get this fix, too.
I think Jeff put it in the latest working copy (3.12.0Beta??) already.

Regards,
Deb

*********************************************
Deb Kerstiens		LANL AOT-8
(505)667-3396		FAX(505)665-5107
email: dkerstiens@lanl.gov
*********************************************

Navigate by Date:
Prev: Re: IOC time 1min=90sec ?? Andrew Johnson
Next: Re: NI VXIcpu-030 Jeff Hill
Index: 1994  <19951996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020 
Navigate by Thread:
Prev: TS - EAST from GMT Gabor Csuka, DESY - Germany
Next: Re: TS - EAST from GMT Andrew Johnson
Index: 1994  <19951996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020 
ANJ, 10 Aug 2010 Valid HTML 4.01! · Home · News · About · Base · Modules · Extensions · Distributions · Download ·
· Search · EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing ·