Re: dbGetSevr on epics 3.14.11

[Ralph Lange <Ralph.Lange@bessy.de>]

 Hi Stephanie,

thanks for reporting this issue!

The bug was introduced by (me) merging in Codeathon 2009 work (revision 
11653, 3 Apr 2009), so it only affects 3.14.11, no earlier versions.
It has been fixed on the 3.14 branch (revision 12087, 19 Jul 2010).
I created a patch file (attached), and pushed this patch to the 
3.14.11+patches branch on Launchpad.

@Andrew: Could you add the issue and the patch file to the Known 
Problems page for 3.14.11, please? I don't know if or how I could do web 
site changes remotely.

Thanks again,
Ralph


On 25.08.2010 21:41, Allison, Stephanie wrote:
> Hello,
>
> I'm upgrading from 3.14.8.2 to 3.14.11 and found a problem with dbGetSevr.  dbGetSevr used to be a prototype in 3.14.8.2 and is now a macro in dbAccessDefs.h:
>
> #define dbGetSevr(PLINK,PSEVERITY) \
>      dbGetAlarm((PLINK),NULL,(PSEVERITY));
>
> That ";" at the end causes problems (ie:   if (dbGetSevr(plink,&severity)) break;)
> and should be removed.
>
> Thank you,
> Stephanie Allison
=== modified file 'src/db/dbAccessDefs.h'
--- src/db/dbAccessDefs.h	2009-04-03 20:54:00 +0000
+++ src/db/dbAccessDefs.h	2010-08-26 15:08:08 +0000
@@ -216,7 +216,7 @@
       ? 0 \
       : ( ( (struct dbAddr *)( (PLNK)->value.pv_link.pvt) ) ) )
 #define dbGetSevr(PLINK,PSEVERITY) \
-    dbGetAlarm((PLINK),NULL,(PSEVERITY));
+    dbGetAlarm((PLINK),NULL,(PSEVERITY))
 
 epicsShareFunc long epicsShareAPI dbPutSpecial(struct dbAddr *paddr,int pass);
 epicsShareFunc struct rset * epicsShareAPI dbGetRset(const struct dbAddr *paddr);