Experimental Physics and
Industrial Control System

Tim Mooney <[email protected]> · Thu, 18 Apr 2013 21:53:08 -0500 (CDT)

Yeah, that's a good point that I had not considered.
I made it unlimited.
Tim

----- Original Message ----- 

> From: "Emmanuel Mayssat" <[email protected]>
> To: "Tim Mooney" <[email protected]>
> Cc: "emmanuel mayssat" <[email protected]>,
> [email protected]
> Sent: Wednesday, April 17, 2013 1:14:29 PM
> Subject: RE: autosave limitation?

> Can this value be increased in the source instead and be available in
> the next release (whenever that is)?

> Applying a patch as simple as this requires
> - create the patch
> - modify the autosave installation script to apply patches
> - document the change
> - inform QA
> - inform coworkers
> when 6 months later, you have machine operations issue and you
> realize that
> - a rogue IOC
> - installed by an intern
> - who did not read the documentation
> - did a manual install and was unaware of the patch
> - ... <insert worse case scenario here>... including downtime and
> hardware damage ;-)

> Could you please increase the value of MAXRESTOREFILES (or implement
> a chained list) in the next version of autosave?

> Regards,
> --
> Emmanuel

> > There's no real reason autosave is limited to 8 files, other than
> > that I
> > didn't know anyone wanted more than that. I haven't tested large
> > numbers
> > of files, but you can edit save_restore.h and change
> > #define MAXRESTOREFILES 8
> > to whatever you want. The number of save files is already unlimited
> > (you
> > can make as many create_monitor_set() calls as you want.)
> >
> > Yes, the number of restore files could be made unlimited. That's
> > what I
> > meant to imply when I said that the list of restore file names
> > could be
> > implemented as a linked list. If someone wants 1000 files, then a
> > linked
> > list is probably called for. If 30 is enough, then
> > #define MAXRESTOREFILES 30
> > seems adequate. All we're doing is allocating an array of pointers.
> >
> > Tim
> >
> > --
> > Tim Mooney ([email protected]) (630)252-5417
> > Software Services Group (www.aps.anl.gov)
> > Advanced Photon Source, Argonne National Lab

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System