Re: pyEpics time stamps

[Mark Rivers <rivers@cars.uchicago.edu>]

Matt Newville is maintaining it. I think he is at ESRF right now.

Mark

Sent from my iPhone

On May 12, 2014, at 6:39 PM, "Eric Norum" <wenorum@lbl.gov<mailto:wenorum@lbl.gov>> wrote:

I’ve found the problem — the code in lib/dbr.py looks just plain wrong:
EPICS2UNIX_EPOCH = 631173600.0 - time.timezone
. . .
def make_unixtime(stamp):
    "UNIX timestamp (seconds) from Epics TimeStamp structure"
    return (EPICS2UNIX_EPOCH + stamp.secs + 1.e-6*int(1.e-3*stamp.nsec))

Problem one — that constant is wrong.  The correct value, as defined in <base>/include/epicsTime.h is: #define POSIX_TIME_AT_EPICS_EPOCH 631152000u
Problem two — what’s ‘time.timezone’ doing in there?   The unix time stamp is in UTC as is the EPICS time stamp.

I propose the following fix:
diff -u lib/dbr.py.orig lib/dbr.py
--- lib/dbr.py.orig 2014-05-12 16:37:58.000000000 -0700
+++ lib/dbr.py 2014-05-12 16:38:00.000000000 -0700
@@ -66,7 +66,7 @@
 MAX_ENUM_STRING_SIZE = 26
 MAX_ENUMS            = 16



-EPICS2UNIX_EPOCH = 631173600.0 - time.timezone
+EPICS2UNIX_EPOCH = 631152000.0



 # create_subscription mask constants
 DBE_VALUE = 1


Who’s maintaining the pyEpics stuff now?
--
Eric Norum
wenorum@lbl.gov<mailto:wenorum@lbl.gov>