Experimental Physics and
Industrial Control System

Heinz,

On 7/13/21 1:09 AM, Heinz Junkes via Tech-talk wrote:
> Dear Matt,
> I have applied the following 2 patches to autosave:

Are you planning for a PR?  https://github.com/epics-modules/autosave/pulls

wrt. patch2.diff  I don't think this is the correct fix.  The nfsMount()
function was removed from RTEMS >=4.10.  Your patch would link against
the non-public helper from Base (rtems_init.c).  (which I think should be static)

So I think that best practice for dependent code would be to call mount()
or mount_and_make_target_path() directly.

https://github.com/epics-base/epics-base/blob/f801ca0501b455bee5e12b836bc24ae74b010535/modules/libcom/RTEMS/posix/rtems_init.c#L264

> Heinz
>
>
>
>> On 13. Jul 2021, at 07:52, Matt Rippa via Tech-talk <tech-talk at aps.anl.gov> wrote:
>>
>> Hello,
>>
>> Our builds of autosave [1] using RTEMS 4.10.2 and EPICS 3.15.x have a warning of an implicit call to nfsMount(). Despite this nfsMount() works fine on iocBoot.
>> In EPICS 7.0.6 and RTEMS5 there's a rule to halt on warning when building autosave. I searched tech-talk and [2] looks similar, moving from RTEMS 4.9 to 4.10.
>>
>> Build host is CentOS-8, RTEMS-mvme2700 (aka 2307) with details in [2]. But the implicit warning also happens on RTEMS-mvme3100 and RTEMS-beatnik.
>>
>> /home/mrippa/MVME2307/rtems/5/bin/powerpc-rtems5-gcc --pipe -B/home/mrippa/MVME2307/rtems/5/powerpc-rtems5/mvme2307/lib/ -specs bsp_specs -qrtems   -fasm   -mcpu=604 -mmultiple -mstring -mstrict-align -meabi       -D_GNU_SOURCE -D_DEFAULT_SOURCE            -DUNIX      -O2 -g -ffunction-sections -fdata-sections   -Wall -Werror-implicit-function-declaration     -DUSE_TYPED_RSET -DDBLOADRECORDSHOOKREGISTER   -DMY_DO_BOOTP=NULL -DHAVE_PPCBUG -DNVRAM_INDIRECT    -D__LINUX_ERRNO_EXTENSIONS__ -DRTEMS_LEGACY_STACK  -I. -I../O.Common -I. -I. -I../os/RTEMS -I../os/default -I.. -I../../../include/compiler/gcc -I../../../include/os/RTEMS -I../../../include -I/home/mrippa/work/vendor/epics-base/include/compiler/gcc -I/home/mrippa/work/vendor/epics-base/include/os/RTEMS -I/home/mrippa/work/vendor/epics-base/include        -c ../os/RTEMS/osdNfs.c
>> ../os/RTEMS/osdNfs.c: In function 'mountFileSystem':
>> ../os/RTEMS/osdNfs.c:45:9: error: implicit declaration of function 'nfsMount'; did you mean 'nfsInit'? [-Werror=implicit-function-declaration]
>>      if (nfsMount(uidhost, path, mntpoint) == OK) {     /* 0 - succeed; -1 - failed */
>>          ^~~~~~~~
>>          nfsInit
>> cc1: some warnings being treated as errors
>> make[3]: *** [/home/mrippa/work/vendor/epics-base/configure/RULES_BUILD:259: osdNfs.o] Error 1
>>
>> Is there something off with my RTEMS or EPICS builds?
>>
>> Thanks,
>> -Matt
>>
>> [1] autosave https://github.com/epics-modules/autosave.git
>> [2] https://epics.anl.gov/tech-talk/2012/msg01045.php
>> [3] rtems5_epics7_build.txt (attached)
>> <rtems5_epics7_build.txt>
>