Re: RTEMS/osdMessageQueue.c

[Michael Davidsaver via Core-talk <core-talk at aps.anl.gov>]

A couple of things.

It looks like the switch to ci-scripts for Base added TEST=NO for the RTEMS builds.
This needs to be removed.

On 5/25/20 10:49 AM, Johnson, Andrew N. via Core-talk wrote:
> tl;dr:  I propose that we delete the RTEMS implementation of osdMessageQueue before making the 7.0.3.2 release, it has bugs which the default implementation doesn’t show.

I don't have a strong objection to this.  Although, I'm not enthused to be
making this change days before a release, when it will go out the door with
very little testing.  Whatever is going on, I suspect that it isn't a
regression (the bugs in the default impl weren't).

How about marking your new test as a skip until after the release?


> The long version:
> 
> While merging 3.15 into 7.0 last night I ran the tests on RTEMS (qemu) and discovered that the implementation of the epicsMessageQueue fails the additional tests that I wrote for this API. I was expecting the Travis-CI builds to fail but

> I forgot that they don’t actually run the tests at all.

I guess there is something to be said for developing on the development branch.


> In the RTEMS implementation of the epicsMessageQueue Eric added an rtems_message_queue_send_timeout() routine which the rtems_message_queue type doesn’t come with. These were the results I saw for these tests:
> 
>> # 6 Single receiver single sender 'Sleepy timeout' tests,
>> #     these should take about 5.00 seconds each:
>> # sleepySender: sending every 0.009 seconds
>> ok 57 - Sent 500 (should be 500)
>> ok 58 - Received 500 (should be 500)
>> # sleepySender: sending every 0.010 seconds
>> ok 59 - Sent 500 (should be 500)
>> ok 60 - Received 500 (should be 500)
>> # sleepySender: sending every 0.011 seconds
>> ok 61 - Sent 500 (should be 500)
>> ok 62 - Received 500 (should be 500)
>> # sleepyReceiver: acquiring every 0.009 seconds
>> not ok 63 - Sent 420 (should be 500)
>> ok 64 - Received 500 (should be 500)
>> # sleepyReceiver: acquiring every 0.010 seconds
>> not ok 65 - Sent 420 (should be 500)
>> ok 66 - Received 500 (should be 500)
>> # sleepyReceiver: acquiring every 0.011 seconds
>> not ok 67 - Sent 420 (should be 500)
>> ok 68 - Received 500 (should be 500)
> 
> So far every time I have run this test the numSent counter has always come back as 420 instead of 500. The fastSender() code looks like this:
> 
>> extern"C"void
>> fastSender(void*arg)
>> {
>>     epicsMessageQueue *q = (epicsMessageQueue *)arg;
>>     numSent= 0;
>>
>>     // Send first without timeout
>>     q->send((void*)msg1, 4);
>>     numSent++;
>>
>>     // The rest have a timeout
>>     while(!sendExit) {
>>         if(q->send((void*)msg1, 4, 0.010) == 0) {
>>             numSent++;
>>         }
>>     }
>>     sendExit = 0;
>>     epicsEventSignal(complete);
>> }
> 
> The epicsMessageQueueSendWithTimeout() routine must sometimes be returning an error (non-zero value) even though it has successfully queued the message; I confirmed that by incrementing a local numFailed counter on the else branch, which always counted to 580. This was the output from a normal run on linux, which is about what I would expect:
> 
>> # sleepyReceiver: acquiring every 0.009 seconds
>> ok 63 - Sent 500 (should be 500)
>> ok 64 - Received 500 (should be 500)
>> # numFailed = 0
>> # sleepyReceiver: acquiring every 0.010 seconds
>> ok 65 - Sent 500 (should be 500)
>> ok 66 - Received 500 (should be 500)
>> # numFailed = 204
>> # sleepyReceiver: acquiring every 0.011 seconds
>> ok 67 - Sent 500 (should be 500)
>> ok 68 - Received 500 (should be 500)
>> # numFailed = 500
> 
> Instead of trying to fix the RTEMS code I propose that we delete the RTEMS implementation completely, causing RTEMS to use the default implementation which gives me these test results when run on qemu:
> 
>> # 6 Single receiver single sender 'Sleepy timeout' tests,
>> #     these should take about 5.00 seconds each:
>> # sleepySender: sending every 0.009 seconds
>> ok 57 - Sent 500 (should be 500)
>> ok 58 - Received 500 (should be 500)
>> # sleepySender: sending every 0.010 seconds
>> ok 59 - Sent 500 (should be 500)
>> ok 60 - Received 500 (should be 500)
>> # sleepySender: sending every 0.011 seconds
>> ok 61 - Sent 500 (should be 500)
>> ok 62 - Received 500 (should be 500)
>> # sleepyReceiver: acquiring every 0.009 seconds
>> ok 63 - Sent 500 (should be 500)
>> ok 64 - Received 500 (should be 500)
>> # numFailed = 80
>> # sleepyReceiver: acquiring every 0.010 seconds
>> ok 65 - Sent 500 (should be 500)
>> ok 66 - Received 500 (should be 500)
>> # numFailed = 80
>> # sleepyReceiver: acquiring every 0.011 seconds
>> ok 67 - Sent 500 (should be 500)
>> ok 68 - Received 500 (should be 500)
>> # numFailed = 80
> 
> Any objections? Discussion?
> 
> - Andrew
> 
> -- 
> Complexity comes for free, simplicity you have to work for.
>