EPICS Controls Argonne National Laboratory

Experimental Physics and
Industrial Control System

2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  <20202021  2022  Index 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  <20202021  2022 
<== Date ==> <== Thread ==>

Subject: [Merge] ~dirk.zimoch/epics-base:fix_one_element_input_link_arrays into epics-base:7.0
From: Dirk Zimoch via Core-talk <core-talk at aps.anl.gov>
To: mp+385269 at code.launchpad.net
Date: Mon, 08 Jun 2020 13:13:24 -0000
Dirk Zimoch has proposed merging ~dirk.zimoch/epics-base:fix_one_element_input_link_arrays into epics-base:7.0.

Commit message:
Allow numeric 1 element arrays in constant input links.
Fixes bug #1882520.

Requested reviews:
  EPICS Core Developers (epics-core)

For more details, see:
https://code.launchpad.net/~dirk.zimoch/epics-base/+git/epics-base/+merge/385269

Links like
  field (INP, [42])
or
  field (INP, [])
did not work, while
  field (INP, [42,7])
or even
  field (INP, [42,])
were fine.

Instead, they were interpreted as CA links, searching for a record with the name "[42]" or "[]", respectively

Now they work as expected.

-- 
Your team EPICS Core Developers is requested to review the proposed merge of ~dirk.zimoch/epics-base:fix_one_element_input_link_arrays into epics-base:7.0.
diff --git a/modules/database/src/ioc/dbStatic/dbStaticLib.c b/modules/database/src/ioc/dbStatic/dbStaticLib.c
index 539ea3a..ceb4ea3 100644
--- a/modules/database/src/ioc/dbStatic/dbStaticLib.c
+++ b/modules/database/src/ioc/dbStatic/dbStaticLib.c
@@ -2330,8 +2330,7 @@ long dbParseLink(const char *str, short ftype, dbLinkInfo *pinfo)
     }
 
     /* Link may be an array constant */
-    if (pstr[0] == '[' && pstr[len-1] == ']' &&
-        (strchr(pstr, ',') || strchr(pstr, '"'))) {
+    if (pstr[0] == '[' && pstr[len-1] == ']') {
         pinfo->ltype = CONSTANT;
         return 0;
     }

Replies:
[Merge] ~dirk.zimoch/epics-base:fix_one_element_input_link_arrays into epics-base:7.0 Dirk Zimoch via Core-talk
[Merge] ~dirk.zimoch/epics-base:fix_one_element_input_link_arrays into epics-base:7.0 noreply--- via Core-talk

Navigate by Date:
Prev: [Bug 1882520] Re: Constant arrary input links of size 1 don't work Dirk Zimoch via Core-talk
Next: [Bug 1882520] Re: Constant arrary input links of size 1 don't work Dirk Zimoch via Core-talk
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  <20202021  2022 
Navigate by Thread:
Prev: [Bug 1882520] Re: Constant arrary input links of size 1 don't work mdavidsaver via Core-talk
Next: [Merge] ~dirk.zimoch/epics-base:fix_one_element_input_link_arrays into epics-base:7.0 Dirk Zimoch via Core-talk
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  <20202021  2022 
ANJ, 22 Oct 2020 Valid HTML 4.01! · Home · News · About · Base · Modules · Extensions · Distributions · Download ·
· Search · EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing ·