Re: Minor issue with base 7.0.4.1

["Johnson, Andrew N. via Core-talk" <core-talk at aps.anl.gov>]

It probably depends on how long it takes to clean the various submodules, which depends on the your file-server, the age of the files it’s removing etc.

I don’t use -j when doing clean/distclean/uninstall because they don’t normally take very long and getting the synchronization right in the build rules is tricky. In your error, one of the subdirectories appears to have been slow to run and the Perl script it needed got removed by the uninstall target before the clean finished.

- Andrew

On Aug 27, 2020, at 5:38 PM, Mark Rivers <rivers at cars.uchicago.edu> wrote:

I just did a fresh clone and I cannot reproduce the problem.  But it was definitely happening in my main working directory.  I don’t know if that is because I have a bunch of other architectures built there as well, or why it won’t fail on this fresh clone.

 

Mark

 

 

From: Johnson, Andrew N. <anj at anl.gov> 
Sent: Thursday, August 27, 2020 4:58 PM
To: Mark Rivers <rivers at cars.uchicago.edu>
Cc: EPICS core-talk <core-talk at aps.anl.gov>
Subject: Re: Minor issue with base 7.0.4.1

 

Hi Mark, 

 

On Aug 26, 2020, at 5:42 PM, Mark Rivers via Core-talk <core-talk at aps.anl.gov> wrote:

 

I just updated base to 7.0.4.1

 

When I run “make –sj clean uninstall” on Centos 7 I get the following error message:

 

corvette:local/epics-devel/base-7.0.4>make -sj clean uninstall

Can't open perl script "/usr/local/epics-devel/base-7.0.4/bin/linux-x86_64/fullPathName.pl": No such file or directory

 

I think the command worked OK, but the error message is disconcerting.

 

Do the changes below fix that particular problem? It will probably behave differently on my machines, so I think you will have to test it to be sure:

 

diff --git a/configure/RULES_TOP b/configure/RULES_TOP

index b956839ec..9cac51c68 100644

--- a/configure/RULES_TOP

+++ b/configure/RULES_TOP

@@ -33,7 +33,7 @@ UNINSTALL_DIRS += $(INSTALL_INCLUDE) $(INSTALL_TEMPLATES) $(DIRECTORY_TARGETS)

 ifneq ($(INSTALL_LOCATION),$(TOP))

   UNINSTALL_DIRS += $(INSTALL_CONFIG)

 endif

-uninstallDirs:

+uninstallDirs: | clean

        $(RMDIR) $(UNINSTALL_DIRS)

 

   # Remove the bin and lib directories if they have no sub-directories

@@ -41,12 +41,12 @@ uninstallDirs:

 EMPTY_INSTALL_DIRS = \

     $(if $(wildcard $(INSTALL_LOCATION_BIN)/*),,$(INSTALL_LOCATION_BIN)) \

     $(if $(wildcard $(INSTALL_LOCATION_LIB)/*),,$(INSTALL_LOCATION_LIB))

-uninstall: archuninstall uninstallDirs

+uninstall: archuninstall uninstallDirs | clean

        $(RMDIR) $(EMPTY_INSTALL_DIRS)

 

 archuninstall: $(addprefix uninstall$(DIVIDER),$(BUILD_ARCHS))

 

-uninstall$(DIVIDER)%:

+uninstall$(DIVIDER)%: | clean

        $(RMDIR) $(addsuffix /$(subst uninstall$(DIVIDER),,$@), \

            $(INSTALL_LOCATION_BIN) $(INSTALL_LOCATION_LIB))

 

 

Those are order-only-prerequisites that tell GNUmake to wait for the ‘make clean’ to finish (if you’ve asked it to do that) before deleting the top-level dir’s. However o-o-p’s don’t always do what you might expect with phony targets.

 

- Andrew

 

-- 

Complexity comes for free, simplicity you have to work for.

-- 

Complexity comes for free, simplicity you have to work for.