EPICS Controls Argonne National Laboratory

Experimental Physics and
Industrial Control System

1994  1995  1996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020  <20212022  2023  2024  Index 1994  1995  1996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020  <20212022  2023  2024 
<== Date ==> <== Thread ==>

Subject: Re: int64in record not sending monitors for larger value changes
From: "Johnson, Andrew N. via Tech-talk" <tech-talk at aps.anl.gov>
To: Kay Kasemir <kasemirk at ornl.gov>
Cc: EPICS tech-talk <tech-talk at aps.anl.gov>
Date: Thu, 29 Jul 2021 15:48:14 +0000
Hello Kay,

On Jul 29, 2021, at 10:37 AM, Kasemir, Kay via Tech-talk <tech-talk at aps.anl.gov> wrote:

I'm trying to use the relatively new 64 bit records in EPICS base..
The output of 'camonitor sixtyfour', however, stops updating as the value grows beyond 0x87654321:

The reason is this section in int64inRecord.c:

/* DELTA calculates the absolute difference between its arguments
 * expressed as an unsigned 32-bit integer */
#define DELTA(last, val) \
    ((epicsUInt32) ((last) > (val) ? (last) - (val) : (val) - (last)))

It only checks for changes in the lower 32 bits of the value.
Maybe the motivation was to always perform an _unsigned_ comparison, but "UInt32" was copy/pasted instead of "UInt64"?

The int64{in,out} record types were created from the long{in,out} types, and it looks like it that particular 32 to 64 conversion was just missed.

Would you mind creating an issue or even a pull request in GitHub for the appropriate change, just so we don’t forget about it?

Thanks!

- Andrew

-- 
Complexity comes for free, simplicity you have to work for.


References:
int64in record not sending monitors for larger value changes Kasemir, Kay via Tech-talk
Re: int64in record not sending monitors for larger value changes Kasemir, Kay via Tech-talk

Navigate by Date:
Prev: Re: int64in record not sending monitors for larger value changes Kasemir, Kay via Tech-talk
Next: RE: Arbitrary rotation angle with areaDetector Plugin Smith, William via Tech-talk
Index: 1994  1995  1996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020  <20212022  2023  2024 
Navigate by Thread:
Prev: Re: int64in record not sending monitors for larger value changes Kasemir, Kay via Tech-talk
Next: StreamDevice protocol file question Wang, Andrew via Tech-talk
Index: 1994  1995  1996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  2019  2020  <20212022  2023  2024 
ANJ, 30 Jul 2021 Valid HTML 4.01! · Home · News · About · Base · Modules · Extensions · Distributions · Download ·
· Search · EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing ·