Experimental Physics and
Industrial Control System

Andrew Johnson via Core-talk <[email protected]> · Mon, 13 May 2019 22:51:44 -0000

Public bug reported:

There can be a mis-match between the record type expected and the type
of the record returned, but a typical use of testdbRecordPtr() will cast
the pointer to the expected type with no warnings produced if it's
wrong, and any test code that accesses a record-specific field will
likely be pointing at the wrong address.

It should be possible to define a new macro in dbUnitTest.h and an
associated helper function that takes the expected record type as an
argument and checks that the type returned matches the one expected,
returning a pointer that is already cast to the expected type. It should
call testAbort() if the wrong record type is found.

** Affects: epics-base
     Importance: Wishlist
         Status: New

** Tags: codeathon

-- 
You received this bug notification because you are a member of EPICS
Core Developers, which is subscribed to EPICS Base.
Matching subscriptions: epics-core-list-subscription
https://bugs.launchpad.net/bugs/1828900

Title:
  dbUnitTest::testdbRecordPtr() is easy to mis-use

Status in EPICS Base:
  New

Bug description:
  There can be a mis-match between the record type expected and the type
  of the record returned, but a typical use of testdbRecordPtr() will
  cast the pointer to the expected type with no warnings produced if
  it's wrong, and any test code that accesses a record-specific field
  will likely be pointing at the wrong address.

  It should be possible to define a new macro in dbUnitTest.h and an
  associated helper function that takes the expected record type as an
  argument and checks that the type returned matches the one expected,
  returning a pointer that is already cast to the expected type. It
  should call testAbort() if the wrong record type is found.

To manage notifications about this bug go to:
https://bugs.launchpad.net/epics-base/+bug/1828900/+subscriptions

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System