Experimental Physics and
Industrial Control System

Jeong Han Lee via Core-talk <core-talk at aps.anl.gov> · Tue, 18 Aug 2020 13:09:16 -0700

Hi Andrew,

Thanks, I got another option which removes -dirty message. However, it
needs more efforts to maintain its own repository continuously.
I prefer to override that dirty message with predefined variables such
as EPICS_VCS_VERSION, or GENVERSIONDEFAULT. With the previous patch, I
can use GENVERSIONDEFAULT for this purpose in the same way I can
override EPICS_SITE_VERSION.

I saw there are some "ordering" issues about these variables, and
proposed the patch with minimal changes.

For me, I can work with "local" CONFIG_SITE_ENV solution if it is
possible. That gives me "minimal effort".

BTW, I don't work for ESS anymore.

Best,
Han

On Tue, Aug 18, 2020 at 11:45 AM Johnson, Andrew N. <anj at anl.gov> wrote:
>
> Hi Han,
>
> On Aug 18, 2020, at 1:26 PM, Jeong Han Lee via Core-talk <core-talk at aps.anl.gov> wrote:
>
>
> CONFIG_SITE_ENV is always needed to be changed. There is no local file
> support. If you can make this happen, it would be greatly appreciated.
>
>
> I agree that this file should have .local support, but I don’t think you should be relying on it (see below).
>
>
> However, I still think we need an option to override the message which
> is shown in the running IOC, because it gives operators or others
> wrong signs about the quality of EPICS base.
>
>
> I recommend that you make the changes you need to the CONFIG_SITE_ENV and any other files, and commit them to a local branch (note that to commit files matching configure/*.local you would have to use git add —force so I would recommend modifying the other files anyway). This will remove the -dirty flag and also give you a local tag (e.g. 7.0.4.1-ESS-1) which captures all the local changes you need to make for a new release and will appear in your git version number.
>
> - Andrew
>
> --
> Complexity comes for free, simplicity you have to work for.
>

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System