Experimental Physics and
Industrial Control System

Mark Rivers via Core-talk <core-talk at aps.anl.gov> · Thu, 17 Sep 2020 01:28:39 +0000

That article is interesting but is about string truncation.  The warnings I am worried about are actually incorrectly flagging buffer overflow. I am hoping there is a cast or other method to avoid them. 

New string functions in base don’t really help me since asyn needs to build, preferably without such warnings, on older versions of base.

Mark

Sent from my iPhone

> On Sep 16, 2020, at 8:16 PM, Chris Johns via Core-talk <core-talk at aps.anl.gov> wrote:
> 
> On 17/9/20 12:02 am, Michael Davidsaver via Core-talk wrote:
>>> On 9/16/20 5:22 AM, Ralph Lange via Core-talk wrote:
>>> My 2cts...
>>> 
>>> I would rather have a safe implementation for copying C strings (taking both the length of source and target as arguments and null-terminating the target) in libCom. Better than having each software module use a different implementation.
>>> Using strncpy() also produces loads of issues on static code analysis systems, as it is declared "forbidden" on Windows.
>> 
>> Well, yes.  We could have our out bespoke "safe" string copying
>> function.  This would certainly do away with at least some warnings as
>> analysis tools would not assign it any special significance.
> 
> We are having to look at similar issues in RTEMS. I found this worth reading ...
> 
> https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/
> 
> Chris

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System