Experimental Physics and
Industrial Control System

Chris Johns via Core-talk <core-talk at aps.anl.gov> · Thu, 17 Sep 2020 11:37:33 +1000

On 17/9/20 11:28 am, Mark Rivers wrote:
> That article is interesting but is about string truncation.  The warnings I am worried about are actually incorrectly flagging buffer overflow. I am hoping there is a cast or other method to avoid them.

OK, I am not across the full context. Reviewing the suggested patch the post
hinted that GCC looks for the terminating nul being written:

if (outStrings) {
 strncpy(&outStrings[i*MAX_ENUM_STRING_SIZE], inStrings[i], MAX_ENUM_STRING_SIZE);
 outStrings[i*MAX_ENUM_STRING_SIZE + MAX_ENUM_STRING_SIZE-1] = '\0';
}

> New string functions in base don’t really help me since asyn needs to build, preferably without such warnings, on older versions of base.

That makes things harder.

Chris

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System