Experimental Physics and
Industrial Control System

mdavidsaver via Core-talk <core-talk at aps.anl.gov> · Sat, 16 May 2020 02:08:29 -0000

Two points.

1. Please avoid merging 7.0 in a feature branch.  git-rebase is the preferred way to update (if necessary).

2. I do my local builds with -Werror=implicit-function-declaration
   which turns up a missing '#define EPICS_PRIVATE_API' in dbChannel.c

../db/dbChannel.c:70:5: error: implicit declaration of function ‘db_init_event_freelists’; did you mean ‘db_init_events’? [-Werror=implicit-function-declaration]
     db_init_event_freelists();
     ^~~~~~~~~~~~~~~~~~~~~~~
     db_init_events

Also, as a minor point.  There is no reason to decorate private API like db_init_event_freelists() with epicsShareFunc unless it is called from test code.
-- 
https://code.launchpad.net/~dirk.zimoch/epics-base/+git/epics-base/+merge/378968
Your team EPICS Core Developers is subscribed to branch epics-base:7.0.

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System